[Buildroot] [PATCH] fs/common.mk: delay evaluation of variables.

Peter Korsgaard jacmet at uclibc.org
Sun Jan 20 19:59:15 UTC 2013


>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be> writes:

 Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout at mind.be>

 Arnout> This makes things easier to understand and more consistent with
 Arnout> the pkg-infra.  For example, it removes the need for '$$@' in
 Arnout> the CMD variables of fs/*/*.mk.

 Arnout> It also makes it possible to update the variables later,
 Arnout> e.g. in the package override file.

 Arnout> It also makes sure that the date will be recorded correctly in
 Arnout> Yann E. Morin's patch that logs the MESSAGE macros to a file.

 Arnout> The fs/*/*.mk must be updated as well because the '$@'
 Arnout> shouldn't be quoted anymore in the CMD variables or the hooks.

 Arnout> The $(eval ...) for the dependencies is redundant, because the
 Arnout> $(ROOTFS_TARGET) variable is already eval'd. Note that it is
 Arnout> only redundant if the evaluation of the uses of the variable is
 Arnout> also delayed.

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list