[Buildroot] [PATCH v2] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Jan 10 20:19:26 UTC 2013


Dear Stefan Fröberg,

On Thu, 10 Jan 2013 21:52:39 +0200, Stefan Fröberg wrote:

> For example:
> 
> DIVINE_CONFIG_FIXUP = divine-config
> 
> or for multiple files:
> 
> IMAGEMAGICK_CONFIG_FIXUP = Magick-config Wand-config

I personally still believe that it is wrong to give just the filename
here and not the full path, i.e:

IMAGEMAGICK_CONFIG_FIXUP = \
	$(STAGING_DIR)/usr/bin/Magick-config \
	$(SATGING_DIR)/usr/bin/Wand-config

With just the filename, my impression is that it is just too much magic
happening behind the scene.

That said, I would not oppose to the current solution being integrated.
I'm just sharing a preference, not a strong opposition here.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list