[Buildroot] [PATCH 2/2] package/tzdata: new package
Yann E. MORIN
yann.morin.1998 at free.fr
Tue Feb 26 20:52:55 UTC 2013
Danomi, Richard, All,
On Tuesday 26 February 2013 Danomi Manchego wrote:
> +define TZDATA_INSTALL_TARGET_CMDS
> + mkdir -p $(TARGET_DIR)/usr/share/zoneinfo
> + cp -a $(@D)/_output/* $(TARGET_DIR)/usr/share/zoneinfo
> + cd $(TARGET_DIR)/usr/share/zoneinfo; \
> + for zone in posix/*; do \
> + ln -s "$${zone}" "$${zone##*/}"; \
> + done
> +endef
>
> Yann,
>
> Today, a co-worker applied these patches, and ran into a small problem
> during the install phase. He had made a mistake while applying the
> companion zic patch, which caused the tzdata package to stop. Then,
> after he fixed his mistake, the tzdata failed to install, because the
> 'ln -s' failed to overwrite symlinks that already exist. So I think
> that it might be good to add an 'rm -f "$${zone##*/}";' before the 'ln
> -s'. (Or at least make it an 'ln -sf', though I personally am
> distrustful of 'ln -sf' due to sometimes unexpected behavior when the
> target of the symlink is a directory.)
OK, I'll apply Richard's "ln -sfn" fix, and re-submit.
Thank you both for the feedback!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list