[Buildroot] [PATCH] ffmpeg: fix build for xtensa

Baruch Siach baruch at tkos.co.il
Wed Dec 25 09:12:39 UTC 2013


Hi Thomas,

On Wed, Dec 25, 2013 at 10:07:15AM +0100, Thomas Petazzoni wrote:
> On Tue, 24 Dec 2013 20:37:46 +0200, Baruch Siach wrote:
> > +ifeq ($(BR2_xtensa),y)
> > +FFMPEG_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -mtext-section-literals"
> > +endif
> 
> Thanks, but to prevent future mistakes, could you provide a slightly
> different version that does:
> 
> FFMPEG_CFLAGS = $(TARGET_CFLAGS)
> 
> ifeq ($(BR2_xtensa),y)
> FFMPEG_CFLAGS += -mtext-section-literals
> endif
> 
> FFMPEG_CONF_ENV = CFLAGS="$(FFMPEG_CFLAGS)"
> 
> This is a little bit better than your version in that we can add things
> to CFLAGS in other places in ffmpeg.mk.

Will do.

Thanks for reviewing.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


More information about the buildroot mailing list