[Buildroot] [PATCH v10 8/8] Makefile: update comment about top-level parallel Makefile

Arnout Vandecappelle arnout at mind.be
Fri Dec 20 15:48:24 UTC 2013


On 20/12/13 14:56, Fabio Porcedda wrote:
> On Thu, Dec 19, 2013 at 6:37 PM, Arnout Vandecappelle<arnout at mind.be>  wrote:
>> >On 18/12/13 11:36, Fabio Porcedda wrote:
>>> >>
>>> >>After the latest patches top-level parallel Makefile is working but
>>> >>there is still an issue when a package has an unspecified optional
>>> >>dependency so change the comment to explain that.
>>> >>
>>> >>Signed-off-by: Fabio Porcedda<fabio.porcedda at gmail.com>
>>> >>---
>>> >>   Makefile | 15 ++++++++++++++-
>>> >>   1 file changed, 14 insertions(+), 1 deletion(-)
>>> >>
>>> >>diff --git a/Makefile b/Makefile
>>> >>index ef2582e..27a6a65 100644
>>> >>--- a/Makefile
>>> >>+++ b/Makefile
>>> >>@@ -42,7 +42,20 @@ export HOSTARCH := $(shell uname -m | \
>>> >>             -e s/macppc/powerpc/\
>>> >>             -e s/sh.*/sh/)
>>> >>
>>> >>-# This top-level Makefile can*not*  be executed in parallel
>>> >>+# Parallel execution of this Makefile is disabled because it could
>>> >>+# change the build result if a package has an unspecified optional
>>> >>+# dependency.
>> >
>> >
>> >  ... or if two packages manipulate the same file in the target directory.
> Ok, added.
>
>> >
>>> >>+# Parallel execution changes the packages building order, that can be
>>> >>+# a problem when a package has an unspecified optional dependency,
>>> >>+# because if that dependency is present when the package is built, it
>>> >>+# is used, otherwise it isn't (but compilation happily proceeds). This
>> >
>> >
>> >  This is a repeat of the first sentence.
> So i just remove it?
>

  Probably better to remove the first sentence, the second one is more 
descriptive.

  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F


More information about the buildroot mailing list