[Buildroot] [PATCH v3 2/2] manual: update for multiple global patch dirs

Ryan Barnett rjbarnet at rockwellcollins.com
Mon Dec 16 16:02:49 UTC 2013


Arnout, All

Ryan Barnett <rjbarnet at rockwellcollins.com> wrote on 12/15/2013 02:01:02 
PM:

> Arnout Vandecappelle <arnout at mind.be> wrote on 12/13/2013 11:19:54 AM:

[...]

>>   Actually, BR2_LINUX_KERNEL_PATCH also supports downloading the patch, 

>> which is not possible with BR2_GLOBAL_PATCH_DIR. As to the others, I 
>> think these options should just be removed (not deprecated, but really 
>> removed, with a clear explanation in Config.in.legacy). And in that 
case 
>> this paragraph becomes redundant.
> 
> I will make note of the BR2_LINUX_KERNEL_PATCH supporting the 
downloading 
> of the patch and that is the only way that it should be used. However, I 

> would rather submit a separate patch series to deprecate the other 
> options. Is this OK with you?
 
I was taking a look at the BR2_LINUX_KERNEL_PATCH option and it appears 
that these patches are applied as a post hook in the patching step. Since 
the advantage with this option is that it supports downloading the patch, 
then I believe you would want these patches to be applied before any user 
patches that would be BR2_GLOBAL_PATCH_DIR. The best example I think of 
for using both BR2_LINUX_KERNEL_PATCH and BR2_GLOBAL_PATCH_DIR is with the 
RT patch. In the RT case, you would want the RT patch to be applied before 
the BR2_GLOBAL_PATCH_DIR.

Would it be acceptable with the patch set to deprecate the option package 
PATCH_DIR options, to make BR2_LINUX_KERNEL_PATCH a pre hook instead of a 
post hook?

Thanks,
-Ryan

[...]


More information about the buildroot mailing list