[Buildroot] [PATCH] package/libgles: postpone the check for a missing GLES provider

Yann E. MORIN yann.morin.1998 at free.fr
Wed Dec 11 12:25:49 UTC 2013


Arnout, All,

On Wednesday 11 December 2013 11:46:59 Arnout Vandecappelle wrote:
> On 10/12/13 20:07, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> >
> > Because some GLES providers may be in BR2_EXTERNAL, $(LIBGLES_DEPENDENCIES)
> > might be empty hwen we test it.
> >
> > So, we can't rely on it to define LIBGLES_CONFIGURE_CMDS, and we must
> > postpone the check until later, ie. at runtime.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > ---
> >   package/opengl/libgles/libgles.mk | 13 +++++++++----
> >   1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/package/opengl/libgles/libgles.mk b/package/opengl/libgles/libgles.mk
> > index ec157ac..c2e1acf 100644
> > --- a/package/opengl/libgles/libgles.mk
> > +++ b/package/opengl/libgles/libgles.mk
> > @@ -22,11 +22,16 @@ ifeq ($(BR2_PACKAGE_GPU_VIV_BIN_MX6Q),y)
> >   LIBGLES_DEPENDENCIES += gpu-viv-bin-mx6q
> >   endif
> >
> > -ifeq ($(LIBGLES_DEPENDENCIES),)
> > +# Because some GLES providers may be in BR2_EXTERNAL,
> > +# $(LIBGLES_DEPENDENCIES) might be empty right here.
> > +# So, we can't rely on it to define LIBGLES_CONFIGURE_CMDS
> > +# right now, and we must postpone the check until later,
> > +# ie. at runtime.
> >   define LIBGLES_CONFIGURE_CMDS
> > -	echo "No libGLES implementation selected. Configuration error."
> > -	exit 1
> > +	if [ -z "$${LIBGLES_DEPENDENCIES}" ]; then \
> 
>   This should be "$(LIBGLES_DEPENDENCIES)", but otherwise it looks like 
> it would work.

I was afraid using a make variable here would be expanded too early
again, that's why I postponed its expansion into the shell command
itself.

But it does not work either, since the variable is not exported.

I'm waiting for feedback from David to confirm either or both
solutions work...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< O_o >==-- '------------.-------:  X  AGAINST      |  /e\  There is no  |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL    |  """  conspiracy.  |
'------------------------------'-------'------------------'--------------------'


More information about the buildroot mailing list