[Buildroot] [PATCH 2 of 4] host-ccache: turn into a proper dependency

Thomas De Schampheleire patrickdepinguin+buildroot at gmail.com
Wed Aug 7 09:28:57 UTC 2013


Hi Thomas,

On Fri, Aug 2, 2013 at 10:54 AM, Samuel Martin <s.martin49 at gmail.com> wrote:
> 2013/8/2 Thomas De Schampheleire <patrickdepinguin+buildroot at gmail.com>:
>> Hi Samuel,
>>
>> On Fri, Aug 2, 2013 at 10:27 AM, Samuel Martin <s.martin49 at gmail.com> wrote:
>>> Hi Thomas (both), all,
>>>
>>> 2013/8/2 Thomas De Schampheleire <patrickdepinguin+buildroot at gmail.com>:
>>>> This patch moves the host-ccache build target from BASE_TARGETS in Makefile
>>>> to an actual host prerequisite in support/dependencies. This causes
>>>> host-ccache to be built as part of the dependencies, before any real package
>>>> is built.
>>>> Since the dependencies are built without ccache anyway, there is no need to
>>>> set HOST_CCACHE_CONF_ENV anymore.
>>>>
>>>> Suggested-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>>>> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>>> Acked-by: Samuel Martin <s.martin49 at gmail.com>
>>>
>>>>
>>>> ---
>>>>
>>>>  Makefile                             |  4 ----
>>>>  package/ccache/ccache.mk             |  6 ------
>>>>  support/dependencies/dependencies.mk |  4 ++++
>>>>  3 files changed, 4 insertions(+), 10 deletions(-)
>>>>
>>>>
>>>> Note: this in itself works, when the dependencies are built (regular 'make'
>>>> for example, or explicit 'make dependencies'). However, if we want to
>>>> supersede patch http://patchwork.ozlabs.org/patch/257372/, that wants
>>>> the following to work:
>>>>
>>>> $ make clean menuconfig
>>>> $ make {barebox,busybox,ctng,linux,uclibc}-menuconfig
>>>>
>>>> then I think something additional is necessary. In the above flow, the
>>>> dependencies target is never used, so host-ccache doesn't get a chance to
>>>> build.
>>> Humm... I don't think so. This patch should be enough to fix the bug #5678.
>>> I mean, to run *-menuconfig, the package need to be extracted beforehand.
>>> I expect the 'dependencies' target is part of dependency list of the
>>> *-extract target (because of host-tar).
>>> If it's done so, then it's ok tm.
>>
>> I may be missing something, but I don't see a dependency of *-extract
>> on 'dependencies'.
> I didn't say it was, but how I expect it should be. ;)
>
>> Also, I tried the scenario and it doesn't work. The compiler used to
>> do the linux-menuconfig is with ccache, and it isn't built
>> automatically, unless you specify 'dependencies' manually.
> Arf... Maybe more work is needed to fix that bug.

What should we do with this series?
And how to proceed with the menuconfig thing?

Thanks,
Thomas


More information about the buildroot mailing list