[Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Apr 29 20:48:59 UTC 2013


Dear Maxime Hadjinlian,

On Sun, 13 Jan 2013 15:23:53 +0100, Maxime Hadjinlian wrote:
> The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
> only a zImage kernel renamed.
> Since Buildroot will build a zImage, the default config uses that should use it
> instead of forcing the user to rename a file.
> 
> Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
> there is no need to specify it on the cmdline.

I don't think this justification is correct. If ext4 is a module, then
rootfstype=ext4 doesn't make it work better. Specifying rootfstype=
tells the kernel what is the root filesystem, so that it doesn't have
to test the different available filesystem drivers.

I'm ok with the change, but I think the commit log is not correct.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list