[Buildroot] [PATCH v5 7/7] package: Introduce NOMMU symbol

Sonic Zhang sonic.adi at gmail.com
Wed Apr 17 07:27:23 UTC 2013


Hi Thomas,

On Wed, Apr 17, 2013 at 5:30 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Sonic Zhang,
>
> On Fri, 12 Apr 2013 18:18:29 +0800, Sonic Zhang wrote:
>
>>  ifeq ($(BR2_BINFMT_FLAT),y)
>>  TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE))
>> +
>> +ifneq ($(BR2_USE_MMU), y)
>
> There shouldn't be any space between the comma and the y.
>
>> +TARGET_CFLAGS += -D__NOMMU__
>>  endif
>>
>>  ifeq ($(BR2_BINFMT_FLAT_SHARED),y)
>
> And you're adding a ifneq condition without adding any endif. Smells
> like untested code :)
>
That's an error when I rebase this patch automatically. Should be fixed soon.

Regards,

Sonic


More information about the buildroot mailing list