[Buildroot] [PATCH] Download packages from github in tar.gz format instead git format.

[Belisko Marek]

Hi Samuel,

On Sat, Sep 15, 2012 at 10:32 PM, Samuel Martin <s.martin49 at gmail.com> wrote:
> Hi Marek, all,
>
> 2012/9/15 Belisko Marek <marek.belisko at gmail.com>:
>> On Sat, Sep 15, 2012 at 5:04 PM, Samuel Martin <s.martin49 at gmail.com> wrote:
>>> Nack.
>>>
>>> Though github provides a "download" tab, with a button to directly
>>> download the source tarball,
>>> the generated tarball url does contain the beginning of the commit sha1.
>>> So, the download url cannot be easily resolved, at least the current
>>> download infrastructure does not support it.
>> I was too fast with this patch. I retest few packages and all was working so
>> realized everything can be converted.
>>
>> I find a way how to get tar.gz from github but not sure if it will be accepted
>> when post a patch:
>>
>> When define in mk file:
>> RASPBERRYPI_FIRMWARE_VERSION = d29291e3e7d90f0137a1416845c7569cf291255e
>> RASPBERRYPI_FIRMWARE_SOURCE =
>> raspberrypi-firmware-$(RASPBERRYPI_FIRMWARE_VERSION).tar.gz
>> RASPBERRYPI_FIRMWARE_SITE =
>> http://github.com/raspberrypi/firmware/tarball/master
>>
>> It start downloading correct git sha1:
>>
>>>>> raspberrypi-firmware d29291e3e7d90f0137a1416845c7569cf291255e Downloading
>> --2012-09-15 21:31:37--
>> http://github.com/raspberrypi/firmware/tarball/master/raspberrypi-firmware-d29291e3e7d90f0137a1416845c7569cf291255e.tar.gz
>> Resolving github.com (github.com)... 207.97.227.239
>> Connecting to github.com (github.com)|207.97.227.239|:80... connected.
>> HTTP request sent, awaiting response... 301 Moved Permanently
>> Location: https://github.com/raspberrypi/firmware/tarball/master/raspberrypi-firmware-d29291e3e7d90f0137a1416845c7569cf291255e.tar.gz
>> [following]
>> --2012-09-15 21:31:37--
>> https://github.com/raspberrypi/firmware/tarball/master/raspberrypi-firmware-d29291e3e7d90f0137a1416845c7569cf291255e.tar.gz
>> Connecting to github.com (github.com)|207.97.227.239|:443... connected.
>> HTTP request sent, awaiting response... 302 Found
>> Location: https://nodeload.github.com/raspberrypi/firmware/tarball/master
>> [following]
>> --2012-09-15 21:31:38--
>> https://nodeload.github.com/raspberrypi/firmware/tarball/master
>> Resolving nodeload.github.com (nodeload.github.com)... 207.97.227.252
>> Connecting to nodeload.github.com
>> (nodeload.github.com)|207.97.227.252|:443... connected.
>> HTTP request sent, awaiting response... 200 OK
>> Length: 102851634 (98M) [application/x-gzip]
>> Saving to: `/home/open-nandra/projects/buildroot-new/dl/raspberrypi-firmware-d29291e3e7d90f0137a1416845c7569cf291255e.tar.gz.tmp'
>>
>> Can I use this method?
>
> Of course you can! :-)
>
>
> BTW, quick tests show that the beginning of the sha1 is enough for
> github to match the revision you want to download, as well as
> prefixing the sha1 with 'g'.
> So, for example, it could be:
> RASPBERRYPI_FIRMWARE_VERSION = d29291e
> RASPBERRYPI_FIRMWARE_SOURCE =
> raspberrypi-firmware-g$(RASPBERRYPI_FIRMWARE_VERSION).tar.gz
> or:
> RASPBERRYPI_FIRMWARE_VERSION = d29291e
> RASPBERRYPI_FIRMWARE_SOURCE =
> raspberrypi-firmware-$(RASPBERRYPI_FIRMWARE_VERSION).tar.gz
Yes I confirmed this method also work.
>
> IMO, this is the way to go for non-tagged version.
>
> For tagged version, the following seems working fine (to be confirmed):
> CPULOAD_VERSION = v0.3
> CPULOAD_SOURCE = kelvincheung-cpuload-$(CPULOAD_VERSION).tar.gz
> CPULOAD_SITE = http://github.com/kelvincheung/cpuload/$(CPULOAD_VERSION)
This will work but this way:
 CPULOAD_SITE =
http://github.com/kelvincheung/cpuload/tarball/$(CPULOAD_VERSION)
(same is used in package package/sqlcipher/sqlcipher.mk)
>
> If it is confirmed that this works, I'll definitely believe that's the
> way to go ;-)
>
> Care to give a try and resend a proper patch?
> And, don't hesitate to add some note in the doc about how to form
> *_SITE and *_SOURCE variables for github hosted projects.
Sure. Will do.
>
>
> Cheers,
>
> --
> Sam

Thanks,

mbe

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com