[Buildroot] [PATCH 1/4] If linux-pam is built, enable dbm functionality in Berkeley DB

Dmitry Golubovsky golubovsky at gmail.com
Tue Sep 11 14:46:02 UTC 2012


Thomas,

On Tue, Sep 11, 2012 at 10:32 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Le Sat,  8 Sep 2012 00:21:03 -0400,
> Dmitry <golubovsky at gmail.com> a écrit :
>
>> +             $(if $(BR2_PACKAGE_LINUX_PAM),--enable-dbm,--disable-dbm) \
>
> I don't really like this. I think you should rather add a configuration
> sub-option in package/berkeleydb/Config.in to enable/disable DBM
> support, and then have berkeleydb.mk test this configuration option,
> and the linux-pam/Config.in package select it.

Well, adding extra config options is what I really wanted to avoid.
But this may be just my way of thinking.

> I don't like when one package recipe pokes into the configuration
> options of another package.

It is not a problem to add such configuration item, I'll do it.

Thanks.

-- 
Dmitry Golubovsky

Anywhere on the Web


More information about the buildroot mailing list