[Buildroot] [PATCHv6 5/5] iw: pkg-config cleanup

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Oct 24 22:52:46 UTC 2012


Dear Gustavo Zacarias,

On Mon, 22 Oct 2012 22:47:55 -0300, Gustavo Zacarias wrote:
> We no longer need to specify PKG_CONFIG_PATH since it's handled by the
> host-pkgconf wrapper.
> 
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>

Acked-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

but a followup patch might be useful:

> -IW_MAKE_ENV = PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig" \
> -	PKG_CONFIG="$(HOST_DIR)/usr/bin/pkg-config" \
> +IW_MAKE_ENV = PKG_CONFIG="$(HOST_DIR)/usr/bin/pkg-config" \
>  	GIT_DIR=$(IW_DIR)

I think the PKG_CONFIG variable can be removed as well. All packages
are being compiled with TARGET_MAKE_ENV, which includes
PATH=$(TARGET_PATH), which ensures that $(HOST_DIR)/usr/bin is in the
PATH before all other directories in your PATH. So 'iw' should
automatically pick up the right pkg-config without having to specify
this PKG_CONFIG variable.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list