[Buildroot] [PATCH 1/2] vala: do not append a -dirty suffix to the valac version number

Simon Dawson spdawson at gmail.com
Fri May 18 13:06:54 UTC 2012


> Why is this needed? We don't apply any patches to vala, and I don't see
> any "-dirty" suffix in valac --version:
>
> ./output/host/usr/bin/valac --version
> Vala 0.15.2

It may be because the Buildroot checkout in which you are testing has
no uncommitted changes. The valac build process calls

$ git diff-index --name-only HEAD 2>/dev/null

and appends the -dirty version suffix if anything is returned. In my
case --- with uncommitted changes to my Buildroot Git checkout --- the
-dirty suffix does get applied. Consequently, for me:

$ ./output/host/usr/bin/valac --version
Vala 0.15.2-dirty

In essence, I think the patch is necessary in order to prevent the
valac build process from falling foul of uncommitted changes in the
local Buildroot checkout. Of course, if you've got uncommitted changes
in the repository in which you're testing, then my theory goes out of
the window...

Simon.


More information about the buildroot mailing list