[Buildroot] [PATCH 0/3] Add CONF_ENABLE and CONF_PKG_ENABLE helper functions

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot at gmail.com> writes:

Hi,

 >> Thanks for working on this and making a proposal.
 >> 
 >> However, on my side, I am not yet convinced that this is actually
 >> making things better than what we have now. What we have now is quite
 >> obvious for the first-time reader, which is very good. Those
 >> CONF_PKG_ENABLE and CONF_ENABLE macros make things a bit too cryptic
 >> from my point of view. This is not an absolutely strong opinion, but I
 >> have the feeling this is on the "we want to make things smaller/shorter
 >> and end up making things cryptic" side of the trade-off. Of course,
 >> others have to comment to share their views on this.

 Thomas> I tend to agree with Thomas that it makes things less obvious
 Thomas> for regular users. The relation between such a CONF_PKG_ENABLE
 Thomas> statement and the corresponding options passed to the configure
 Thomas> script is not apparent, which confuses people.

I must say I agree.

-- 
Bye, Peter Korsgaard