[Buildroot] [PATCH 5/6] Fix installation for the lighttpd package
Maxime Ripard
maxime.ripard at free-electrons.com
Tue Mar 20 09:42:36 UTC 2012
Le 20/03/2012 00:51, Arnout Vandecappelle a écrit :
> On Monday 19 March 2012 16:59:39 Maxime Ripard wrote:
>> package/lighttpd/lighttpd.conf | 445 ++++++++++++++++++++++++++++++++++++++++
>
> Same remark as for systemd: wouldn't it be better to patch the upstream
> file instead of copying it? Also, why did you revert the disabling of
> range requests for pdf documents?
Well, here, the default values are sensible.
I mean, for a default configuration file, it is a normal behaviour for a
modern webserver to start it with its own UID/GID and to enable ipv6.
I don't see why they would accept a patch that disable these.
For PDF ranges option, it relies on a regex, and we don't always compile
with pcre, so I turned it down. Moreover, it's to fix a broken behaviour
of Adobe Acrobat's plugin that don't display the correct file size from
what I can understand, so nothing really critical here.
Here, same thing, maybe a patch against the source would be more
convenient and lightweight for us, I don't know.
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list