[Buildroot] [PATCH 11/13] cmake: move creation of toolchain file to package/pkg-cmaketargets.mk

Thomas De Schampheleire patrickdepinguin+buildroot at gmail.com
Fri Mar 9 08:54:08 UTC 2012


On Fri, Mar 9, 2012 at 8:53 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Le Fri, 9 Mar 2012 07:54:32 +0100,
> Thomas De Schampheleire <patrickdepinguin+buildroot at gmail.com> a écrit :
>
>> Currently, BASE_TARGETS is still:
>> $(BASE_TARGETS): dirs
>> $(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake
>>
>> Now that the recipe for toolchainfile.cmake has moved, I find it a bit
>> strange that the 'magic' path to this file still appears here.
>> What about creating a nicer name and using that in BASE_TARGETS, and
>> let the pkg-cmaketargets.mk file resolve the nice name into the actual
>> path?
>
> Something like:
>
> CMAKE_TOOLCHAIN_FILE=$(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake
>
> in pkg-cmaketargets.mk
>
> and then in the main Makefile:
>
> $(BASE_TARGETS): dirs $(CMAKE_TOOLCHAIN_FILE)
>
> Is this what you're suggesting?

Although I was thinking of an actual target, like 'cmake-prepare' or
something, using a variable like you suggest above is also fine with
me. It's maybe more simple and equally covers my comment.

Best regards,
Thomas


More information about the buildroot mailing list