[Buildroot] [PATCH 3/4] lua: remove 3 sub-options, always install all

[François Perrad]

2012/7/30 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Le Mon, 30 Jul 2012 08:31:29 +0200,
> Francois Perrad <fperrad at gmail.com> a écrit :
>
>> ---
>>  package/lua/Config.in |   18 ------------------
>>  package/lua/lua.mk    |   17 +----------------
>>  2 files changed, 1 insertion(+), 34 deletions(-)
>>
>> diff --git a/package/lua/Config.in b/package/lua/Config.in
>> index 06f3046..fc6bb4c 100644
>> --- a/package/lua/Config.in
>> +++ b/package/lua/Config.in
>> @@ -32,29 +32,11 @@ endchoice
>>
>>  if BR2_PACKAGE_LUA
>>
>> -config BR2_PACKAGE_LUA_COMPILER
>> -     bool "lua compiler"
>> -     select BR2_PACKAGE_LUA_SHARED_LIBRARY
>> -     help
>> -       Install luac binary
>> -
>> -config BR2_PACKAGE_LUA_INTERPRETER
>> -     bool "lua interpreter"
>> -     select BR2_PACKAGE_LUA_SHARED_LIBRARY
>> -     help
>> -       Install lua binary
>
> Wouldn't it make sense to keep options for the compiler and
> interpreter? I presume using the compiler on the target is fairly
> uncommon (you would rather do the compilation at build time, no?).
>

The lua bytecode is platform dependent (the header contains the
endianness and the size of some types : int, size_t, Instruction &
lua_Number).
So, the Lua code cannot be compiled on the host and interpreted on target.

> And Lua can be used as a library without the separate /usr/bin/lua
> interpreter, no?
>
> But maybe this last option (the interpreter) is more complicated to
> handle with the choice between lua and luajit.
>

Since lua & luac are linked against the shared library, there are
small (< 10KB).
And the post-build script (BR2_ROOTFS_POST_BUILD_SCRIPT) could remove
them if needed.

So, I think that the 3 sub-options could be removed.

François

> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot