[Buildroot] [PATCH 07/11] ext-tool.mk: add fancy messages

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jul 22 14:26:41 UTC 2012


Le Sun, 22 Jul 2012 15:28:35 +0200,
Samuel Martin <s.martin49 at gmail.com> a écrit :

> 
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
> 
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 293bf4f..0861673 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -65,6 +65,7 @@ INFLATE.tar  = cat
>  
>  # MESSAGE Macro -- display a message in bold type
>  MESSAGE     = echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION) $(1)$(TERM_RESET)"
> +MESSAGE2    = echo "$(TERM_BOLD)>>> $(1) $(2)$(TERM_RESET)"
>  TERM_BOLD  := $(shell tput smso)
>  TERM_RESET := $(shell tput rmso)

Maybe we need:

MESSAGE	= echo "$(TERM_BOLD)>>> $(1) $(2)$(TERM_RESET)"
PKG_MESSAGE = $(call MESSAGE,$($(PKG)_NAME) $($(PKG)_VERSION),$(1))

And then use PKG_MESSAGE in the package infrastructure, and MESSAGE in
other places. But definitely MESSAGE vs. MESSAGE2 is ugly.

And maybe the MESSAGE definition would have to be somewhere outside of
pkg-utils.mk since it's not package related anymore.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list