[Buildroot] [PATCH] avahi: only install default.script/S05avahi-setup.sh if not present in fs skeleton

Peter Korsgaard jacmet at uclibc.org
Fri Jul 20 08:57:25 UTC 2012


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 Thomas> Le Thu, 19 Jul 2012 21:53:45 -0400,
 Thomas> Danomi Manchego <danomimanchego123 at gmail.com> a écrit :

 >> > If avahi is built before
 >> > Busybox, then you'll have the Avahi script. If Busybox is built before
 >> > Avahi, then you'll have the Busybox script. This doesn't look correct.
 >> 
 >> Would it be appropriate to add something like this to busybox.mk, so that
 >> Avahi always gets built first?
 >> 
 >> ifeq ($(BR2_PACKAGE_AVAHI),y)
 >> # Compile Avahi first, to ensure proper preference of conditional
 >> udhcpc/default.script installations
 >> BUSYBOX_DEPENDENCIES += avahi
 >> endif

 Thomas> Well, I think the whole idea of testing whether a configuration file has
 Thomas> already been copied or not to the target filesystem to avoid
 Thomas> overwriting files from the skeleton is not nice (I think using the
 Thomas> post-build script to overwrite configuration files is a much better
 Thomas> idea), but I know Peter wants this to work.

I don't really feel that strongly about it.

 Thomas> The parts around avahi-autoipd are obviously here for a reason,
 Thomas> but why does it need to test for ip= and nfsroot= in the kernel
 Thomas> command line in Avahi case and not in Busybox case?

 Thomas> One possibility would be to simply put the Avahi variant of the
 Thomas> script into the Busybox package. When Avahi is not installed,
 Thomas> the avahi-autoipd tests would simply ensure that the script
 Thomas> does not try to use Avahi.

That was my thought exactly. I had a quick look at it just before I got
ill, but then forgot about it.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list