[Buildroot] [PATCH v2] libmad: Add optimization config options
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Jul 13 19:41:47 UTC 2012
Hello,
Le Fri, 13 Jul 2012 19:25:12 +0200 (CEST),
Benoît Thébaudeau <benoit.thebaudeau at advansee.com> a écrit :
> Changes for v2:
> - Factorize the 'able' in the $(if ).
I prefer the solution in v1 with regard to this, as it is much easier
to read.
> +choice
> + prompt "Speed vs. accuracy"
> + default BR2_PACKAGE_LIBMAD_SPEED_ACCURACY
What about calling those options:
BR2_PACKAGE_LIBMAD_OPTIMIZATION_SPEED
BR2_PACKAGE_LIBMAD_OPTIMIZATION_ACCURACY
BR2_PACKAGE_LIBMAD_OPTIMIZATION_DEFAULT
> +config BR2_PACKAGE_LIBMAD_SPEED_ACCURACY
> + bool "Optimize for both speed and accuracy"
This should rather be:
bool "Default"
or something like that. Technically, this option does not enable any
special optimization for both speed and accuracy, it just uses the
default options.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list