[Buildroot] [PATCH 04/14] libeina: Add new package along with EFL infrastructure

Peter Korsgaard jacmet at uclibc.org
Thu Jan 26 22:03:15 UTC 2012


>>>>> "Will" == Will Newton <will.newton at gmail.com> writes:

 Will> Signed-off-by: Will Newton <will.newton at imgtec.com>
 Will> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
 Will> ---

 Will> +++ b/package/efl/libeina/Config.in
 Will> @@ -0,0 +1,4 @@
 Will> +config BR2_PACKAGE_LIBEINA
 Will> +	bool "libeina"
 Will> +	help
 Will> +	  Eina is a tiny library to handle data types (list, hash, etc.)

Heh, the compressed tarball is almost 10MB.

You forgot to add an upstream URL. I've added
http://trac.enlightenment.org/e/wiki/Eina

 Will> diff --git a/package/efl/libeina/libeina.mk b/package/efl/libeina/libeina.mk
 Will> new file mode 100644
 Will> index 0000000..3ed43db
 Will> --- /dev/null
 Will> +++ b/package/efl/libeina/libeina.mk
 Will> @@ -0,0 +1,16 @@
 Will> +#############################################################
 Will> +#
 Will> +# libeina
 Will> +#
 Will> +#############################################################
 Will> +
 Will> +LIBEINA_VERSION = 1.1.0
 Will> +LIBEINA_SOURCE = eina-$(LIBEINA_VERSION).tar.bz2
 Will> +LIBEINA_SITE = http://download.enlightenment.org/releases/
 Will> +LIBEINA_AUTORECONF = YES

You're not patching any auto* files, so no need to autoreconf.

Otherwise it looks good - Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list