[Buildroot] [PATCH] DOWNLOAD: change $1=DIRECTORY_URL, $2=FILE_NAME to $1=FULL_FILE_URL, $2=FILE_NAME

Alvaro Gamez alvaro.gamez at hazent.com
Sat Feb 18 12:11:40 UTC 2012


That's right. I can solve that in a moment.

2012/2/18 Arnout Vandecappelle <arnout at mind.be>

>  Sorry, there are still a few things I missed before...
>
> On Friday 17 February 2012 12:10:01 Alvaro G. M wrote:
>
> [snip]
> > diff --git a/package/Makefile.package.in b/package/Makefile.package.in
> > index 33461b4..a96031e 100644
> > --- a/package/Makefile.package.in
> > +++ b/package/Makefile.package.in
> > @@ -203,11 +203,11 @@ endef
> >  # to prepend the path with a slash: scp://[user@]host:/absolutepath
> >  define DOWNLOAD_SCP
> >       test -e $(DL_DIR)/$(2) || \
> > -     $(SCP) $(call stripurischeme,$(call qstrip,$(1)))/$(2) $(DL_DIR)
> > +     $(SCP) '$(call stripurischeme,$(call qstrip,$(1)))' $(DL_DIR)/$(2)
> >  endef
> >
> >  define SOURCE_CHECK_SCP
> > -     $(SSH) $(call domain,$(1),:) ls $(call notdomain,$(1)/$(2),:) >
> /dev/null
> > +     $(SSH) $(call domain,$(1),:) ls $(call notdomain,$(1),:) >
> /dev/null
>
>  There should probably be quotes here as well.  Although, when you use
> scp, it's not very likely that the directory name contains evil characters.
>
> >  endef
> >
> >  define SHOW_EXTERNAL_DEPS_SCP
> > @@ -238,11 +238,11 @@ endef
> >
> >  define DOWNLOAD_WGET
> >       test -e $(DL_DIR)/$(2) || \
> > -     $(WGET) -P $(DL_DIR) $(call qstrip,$(1))/$(2)
> > +     $(WGET) -O $(DL_DIR)/$(2) '$(call qstrip,$(1))'
> >  endef
> >
> >  define SOURCE_CHECK_WGET
> > -  $(WGET) --spider $(call qstrip,$(1))/$(2)
> > +  $(WGET) --spider $(call qstrip,$(1))
>
>  Here quotes are definitely needed or we get in trouble with URLs
> containing & or ;.
>
>
>  Regards,
>  Arnout
>
>
> --
> Arnout Vandecappelle                               arnout at mind be
> Senior Embedded Software Architect                 +32-16-286540
> Essensium/Mind                                     http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR
> Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
>



-- 
Álvaro Gámez Machado
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120218/91ed5f34/attachment.html>


More information about the buildroot mailing list