[Buildroot] [RFC PATCH 4/6] apply-patches.sh: directories are considered as a collection of patches

[Ludovic Desroches]

Hello Arnout,

On Fri, Feb 10, 2012 at 11:40:46PM +0100, Arnout Vandecappelle wrote:
>    On Monday 06 February 2012 02:47:17 ludovic.desroches at atmel.com wrote:
> 
>    > From: Ludovic Desroches <ludovic.desroches at atmel.com>
> 
>    >
> 
>    > Behaviour of directories is changed: it is no more considered as an
>    overlay,
> 
>    > but rather a collection of patches. Subdirectories are not supported.
> 
>    Actually, I think the directory feature could be removed completely.
>    It's
> 
>    not used anywhere at the moment and I don't see why anyone would want
>    to use it.
> 

Even if this feature is not used, I think we have to keep it. For instance,
into an archive we may have several directories with patches into each of them.

>    > -# Check for rejects because if there are some, even if patches are
>    well
> 
>    > -# applied, at the end it will complain about rejects into builddir.
> 
>    > -if [ "`find ${builddir}/ '(' -name '*.rej' -o -name '.*.rej' ')'
>    -print`" ] ; then
> 
>    > - echo "There are remaining reject files into ${builddir}, please
>    delete them."
> 
>    > -fi
> 
>    I still think it's better to keep these checks before the definition
> 
>    of the apply_patch function.
> 

Unintentional mistake, I will keep these checks.

> 
>    > + echo "Applying $patch using ${type}: "
> 
>    > + echo ${1} >> ${builddir}/.applied_patches_list
> 
>    Shouldn't this be 'echo $path/$patch' ? Not that it matters that
>    much...
> 

You're right, I have seen it after sending patches.

Regards

Ludovic