[Buildroot] [PATCH] new program: usb_modeswitch_data Signed-off-by: J.C. Woltz <jwoltz at gmail.com>

Thomas De Schampheleire patrickdepinguin+buildroot at gmail.com
Fri Feb 10 07:37:18 UTC 2012


Hi,

On Fri, Feb 10, 2012 at 12:51 AM, J.C. Woltz <jwoltz at gmail.com> wrote:
> From: "J.C. Woltz" <jwoltz at gmail.com>

You don't need the From: line.
Instead, the Signed-off-by: should appear here, and not in the Subject line.

>
> ---
>  package/Config.in                                  |    1 +
>  package/usb_modeswitch_data/Config.in              |    7 +++++
>  .../usb_modeswitch_data-makefile.patch             |   24 ++++++++++++++++++
>  package/usb_modeswitch_data/usb_modeswitch_data.mk |   26 ++++++++++++++++++++
>  4 files changed, 58 insertions(+), 0 deletions(-)
>  create mode 100644 package/usb_modeswitch_data/Config.in
>  create mode 100644 package/usb_modeswitch_data/usb_modeswitch_data-makefile.patch
>  create mode 100644 package/usb_modeswitch_data/usb_modeswitch_data.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index c679652..ff11cd0 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -220,6 +220,7 @@ source "package/uboot-tools/Config.in"
>  source "package/udev/Config.in"
>  source "package/unionfs/Config.in"
>  source "package/usb_modeswitch/Config.in"
> +source "package/usb_modeswitch_data/Config.in"
>  source "package/usbmount/Config.in"
>  source "package/usbutils/Config.in"
>  source "package/wipe/Config.in"
> diff --git a/package/usb_modeswitch_data/Config.in b/package/usb_modeswitch_data/Config.in
> new file mode 100644
> index 0000000..cd584ce
> --- /dev/null
> +++ b/package/usb_modeswitch_data/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_USB_MODESWITCH_DATA
> +       bool "usb_modeswitch_data"
> +       select BR2_PACKAGE_USB_MODESWITCH
> +       help
> +         USB mode switcher data
> +         Contains udev rules and other data
> +

I think a 'depends on' clause is more appropriate than 'select' here.

As a general rule, the help text should contain the URL to the project.

> diff --git a/package/usb_modeswitch_data/usb_modeswitch_data-makefile.patch b/package/usb_modeswitch_data/usb_modeswitch_data-makefile.patch
> new file mode 100644
> index 0000000..024bc76
> --- /dev/null
> +++ b/package/usb_modeswitch_data/usb_modeswitch_data-makefile.patch
> @@ -0,0 +1,24 @@
> +diff -Nura usb_modeswitch_data-20120120.orig/Makefile usb_modeswitch_data-20120120/Makefile
> +--- usb_modeswitch_data-20120120.orig/Makefile 2012-01-20 17:25:32.000000000 -0500
> ++++ usb_modeswitch_data-20120120/Makefile      2012-02-06 14:20:47.000000000 -0500
> +@@ -12,9 +12,9 @@
> +
> + clean:
> +
> +-install: files-install db-install rules-reload
> ++install: files-install db-install
> +
> +-install-packed: files-install db-install-packed rules-reload
> ++install-packed: files-install db-install-packed
> +
> + files-install:
> +       install -d $(PREFIX)/share/usb_modeswitch
> +@@ -50,7 +50,7 @@
> +               fi \
> +       fi
> +
> +-uninstall: files-uninstall rules-reload
> ++uninstall: files-uninstall
> +
> + files-uninstall:
> +       $(RM) $(RULESDIR)/40-usb_modeswitch.rules

I know that it's not yet the case for many patches in the buildroot
tree, but patches should also have a short description at the top, and
a Signed-off-by: clause.


> diff --git a/package/usb_modeswitch_data/usb_modeswitch_data.mk b/package/usb_modeswitch_data/usb_modeswitch_data.mk
> new file mode 100644
> index 0000000..9f1b3ff
> --- /dev/null
> +++ b/package/usb_modeswitch_data/usb_modeswitch_data.mk
> @@ -0,0 +1,26 @@
> +#############################################################
> +#
> +# usb_modeswitch_data
> +#
> +#############################################################
> +
> +USB_MODESWITCH_DATA_VERSION = 20120120
> +USB_MODESWITCH_DATA_SOURCE = usb-modeswitch-data-$(USB_MODESWITCH_DATA_VERSION).tar.bz2
> +USB_MODESWITCH_DATA_SITE = http://www.draisberghof.de/usb_modeswitch
> +USB_MODESWITCH_DATA_DEPENDENCIES = usb_modeswitch
> +
> +define USB_MODESWITCH_DATA_BUILD_CMDS
> +       $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
> +endef
> +
> +define USB_MODESWITCH_DATA_INSTALL_TARGET_CMDS
> +       $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> +endef
> +
> +
> +define USB_MODESWITCH_DATA_CLEAN_CMDS
> +       $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) clean
> +endef
> +
> +$(eval $(call GENTARGETS))
> +
> --
> 1.7.5.4

Best regards,
Thomas


More information about the buildroot mailing list