[Buildroot] [RFC 01/15] legal-info: new target to echo basic per-package legal info
Luca Ceresoli
luca at lucaceresoli.net
Wed Feb 1 21:07:17 UTC 2012
Hi Arnout,
thanks for the review.
Arnout Vandecappelle wrote:
> On Sunday 29 January 2012 16:11:34 Luca Ceresoli wrote:
>> Signed-off-by: Luca Ceresoli<luca at lucaceresoli.net>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind)<arnout at mind.be>
>
>> ---
>> Makefile | 9 ++++++++-
>> package/Makefile.package.in | 6 ++++++
>> 2 files changed, 14 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 912012f..507fd78 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -354,6 +354,11 @@ HOST_DEPS = $(sort $(foreach dep,\
>> $($(dep))))
>> HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
>>
>> +TARGETS_LEGAL_INFO:=$(patsubst %,%-legal-info,\
>> + $(filter-out makedevs,\
>> + $(patsubst host-%,%,\
>> + $(TARGETS) $(BASE_TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
>> +
> Are we creating the legal info of the target or the SDK here? If it is
> for the target, the host-% are not needed since they are not distributed.
> I think there should be a separate command for the SDK's legal info.
The intent was to save also the SDK (toolchain), except it does not
currently work.
But this raises a more high-level question about what we want to save
here: target packages, host packages (toolchain and others), BR sources,
BR .config? I think the right answer is "all of them", but I've put it
on my list of issues to be discussed in the BDD.
>
> [snip]
>> +$(1)-legal-info: $(1)-source
>> + @echo -e "$(1)\t$$($(3)_VERSION)\t$$($(3)_LICENSE)"
>> +
> Minor detail: if this patch is separate from the one that saves the source
> tarball, the dependency on $(1)-source is unnecessary.
Ops, this is the result of the massive rebases I did before posting.
Moved to the right patch, thanks.
Luca
More information about the buildroot
mailing list