[Buildroot] [PATCH v2 1/2] Makefile: rename cross target -> toolchain

Fabio Porcedda fabio.porcedda at gmail.com
Sat Dec 22 13:45:18 UTC 2012


On Sat, Dec 22, 2012 at 1:45 PM, Samuel Martin <s.martin49 at gmail.com> wrote:
> Hi Fabio,
>
> 2012/12/21 Fabio Porcedda <fabio.porcedda at gmail.com>:
>> - Use a more descriptive name, the same of the "toolchain" directory.
>> - Add missing dependencies to be able to successfully use the target
>>   right after the configuration.
>> - Move to a better position.
>> - Documentation it in the help target.
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
>> ---
>>  Makefile | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 4b09437..458b8c5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config
>>
>>  prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>>
>> +toolchain: prepare dirs dependencies $(BASE_TARGETS)
>> +
>>  world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
> Any reason to not make the world target depend on the toolchain and
> $(TARGETS_ALL) targets?
> IOW:
> world: toolchain $(TARGETS_ALL)

I've done exactly that in the following patch 2/2

> Otherwise, it looks good to me with few words in the manual as already
> mentioned by Arnout.

Thanks for the review

Best regards
--
Fabio Porcedda


More information about the buildroot mailing list