[Buildroot] [PATCH] libpng: bump version and add apng support (required by firefox)

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Aug 10 07:02:32 UTC 2012


Hello Stefan,

Le Thu, 09 Aug 2012 22:22:06 +0300,
Stefan Fröberg <stefan.froberg at petroprogram.com> a écrit :

> Signed-off-by: Stefan Froberg <stefan.froberg at petroprogram.com>
> ---

Thanks for this patch. A few comments:

 (1) Your patch has been line-wrapped by your e-mail client. Try to use
     git send-email instead, which will guarantee that your patch
     remains intact and can be applied properly.

 (2) As far as I know, the bump from libpng 1.4 to libpng 1.5 changes
     the API, and is therefore causing build failures in other
     packages. Have you tested things like DirectFB and other packages
     that rely on libpng?

 (3) Is this apng feature something that is being integrated in the
     upstream version of libpng? In Buildroot, we don't like carrying
     patches that add features to packages. Imagine we later want to
     bump libpng to version 1.5.10 or 1.5.11, we'd have to refresh the
     patch, which becomes complicated if we accumulate many large
     patches.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list