[Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Sep 27 21:51:45 UTC 2011


Baruch,

Le Mon, 26 Sep 2011 10:48:57 +0300,
Baruch Siach <baruch at tkos.co.il> a écrit :

> The "" string is not equal to the empty string. This fixes build
> errors like:
> 
> arm-none-linux-gnueabi-gcc: : No such file or directory
> 
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>

For some reason, your patch does not seem to apply on current master.

>  # march/mtune/floating point mode needs to be passed to the external toolchain
>  # to select the right multilib variant
> -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
>  TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
>  TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'

Should be use TOOLCHAIN_EXTERNAL_CUSTOM_ARGS in these two lines
instead ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list