[Buildroot] [PATCH v5] package: add opencv
Arnout Vandecappelle
arnout at mind.be
Wed Oct 26 21:21:57 UTC 2011
On Monday, October 24, 2011 15:35:32 Peter Korsgaard wrote:
[snip]
> Samuel> +# Build type
> Samuel> +OPENCV_CONF_OPT += -DCMAKE_BUILD_TYPE=$(if
> $(BR2_ENABLE_DEBUG),Debug,Release)
>
> While this works it looks quite different than other packages - We
> normally do:
>
> OPENCV_CONF_OPT += \
> blah=.. \
> blih=.. \
> bloh=..
>
> ifeq ($(BR2_PACKAGE_BLAH))
> OPENCV_CONF_OPT += BLAH=on
> OPENCV_DEPENDENCIES += blah
> else
> OPENCV_CONF_OPT += BLAH=OFF
> endif
>
> ..
>
> I've rewritten it to use that form.
Actually, for that particular one you haven't :-)
Also I think it's important to use
ifeq ($(BR2_PACKAGE_BLAH),y)
so you can easily disable it on the command line with
make BR2_PACKAGE_BLAH=n
(Of course, 'make BR2_PACKAGE_BLAH=' would still work, but it's less
intuitive.)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
More information about the buildroot
mailing list