[Buildroot] [PATCH] Remove / after $(PKG)_DIR_PREFIX

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Oct 2 17:12:27 UTC 2011


Hello,

Le Sun,  2 Oct 2011 01:43:46 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout at mind.be> a écrit :

> With the automatic derivation of the package directory, the $(PKG)_DIR_PREFIX
> variable already contains a final /.  Therefore there is no need to have an
> additional / after the uses of this variable.

For the "package: fix bootloader building" patch I posted a few days
ago, I hesitated between :

 * Ensuring that pkgparentdir returns a string with no final /

or

 * Changing the test for bootloaders from "boot" to "boot/".

The latter was the simplest solution, so it's the one I did. But seeing
your patch, I think the former solution would be better, because I
don't really like the fact of not having a / between
$($(PKG)_DIR_PREFIX) and the rest of the path.

I'll rework my pkg-infra-urgent branch to take this into account.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list