[Buildroot] [git commit] busybox: only install S01logging if syslogd applet is enabled

Peter Korsgaard jacmet at sunsite.dk
Wed Nov 23 21:41:45 UTC 2011


>>>>> "Peter" == Peter Korsgaard <jacmet at sunsite.dk> writes:

Hi,

 Maxime> While it shouldn't happen in the common use-case, because of
 Maxime> the dependency we set on busybox in all the logger packages, if
 Maxime> the user put his init script for another logger in the
 Maxime> skeleton, it will always remove it, and install the default
 Maxime> one.

 Maxime> Maybe the common name was not such a good idea, and that we
 Maxime> should have a distinct name for each init scripts. Or we revert
 Maxime> this commit. I don't know.

 Peter> For 2011.11 I would suggest we just remove the 2nd part (E.G. removal of
 Peter> init script if syslog daemon isn't enabled) - The first part is needed
 Peter> to support custom S01logging scripts with busybox (E.G. I have projects
 Peter> where we log to shared memory instead of files, so you need -S option to
 Peter> syslogd).

 Peter> Once 2011.11 is out, then we should probably rename the files to work
 Peter> around this.

 Peter> I'll fix - Thanks for bringing it out.

Ehh, I had a closer look, and I don't see any issues:

- If sysklogd applet is enabled in busybox we install S01logging
- If "big" sysklogd is enabled we don't install anything (bug)
- If rsyslogd is enabled we install S01rsyslog

So we don't have multiple system loggers using the same file name - Did
you just mean that we should rename S01logging to something like
S01bbsysklog instead?

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list