[Buildroot] [PATCH 1/2] toolchain: Correct test for external tools symlink creation

Yann E. MORIN yann.morin.1998 at anciens.enib.fr
Tue Nov 1 10:46:11 UTC 2011


Stany, All,

On Tuesday 01 November 2011 01:53:38 Stany MARCEL wrote:
> When the external tools chain is installed in a path that match one of
> the first case test, all symlink are created to the external
> wrapper. The proposed solution is to test only the base name not the
> full path.
> 
> Signed-off-by: Stany MARCEL <stanypub at gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at anciens.enib.fr>

Peter, this should go in before the -rc, if possible.

> ---
>  toolchain/toolchain-external/ext-tool.mk |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
> index 8287916..572917f 100644
> --- a/toolchain/toolchain-external/ext-tool.mk
> +++ b/toolchain/toolchain-external/ext-tool.mk
> @@ -318,9 +318,9 @@ $(STAMP_DIR)/ext-toolchain-installed: $(TOOLCHAIN_EXTERNAL_DEPENDENCIES)
>  $(HOST_DIR)/usr/bin/ext-toolchain-wrapper: $(STAMP_DIR)/ext-toolchain-installed
>  	mkdir -p $(HOST_DIR)/usr/bin; cd $(HOST_DIR)/usr/bin; \
>  	for i in $(TOOLCHAIN_EXTERNAL_CROSS)*; do \
> -		case "$$i" in \
> +		base=$${i##*/}; \
> +		case "$$base" in \
>  		*cc|*cc-*|*++|*++-*|*cpp) \
> -			base=$${i##*/}; \
>  			ln -sf $(@F) $$base; \
>  			;; \
>  		*) \
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list