[Buildroot] RFC: package patching

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Nov 16 18:03:06 UTC 2011


Le Wed, 16 Nov 2011 07:44:54 +0100,
Thomas De Schampheleire <patrickdepinguin+buildroot at gmail.com> a écrit :

> > As Arnout suggests, I think that most packages should just have
> > patches whose filename do not contain the version. Only packages
> > that support multiple versions would have subdirectories.
> 
> I'm not sure if this is so black-and-white. If a patch backports a
> change from 1.2.3 to 1.2.2, then IMO the patch should really be named
> 1.2.2, even if only 1.2.2 is present in Buildroot. If it is named
> without version, then it will also be taken along when bumping the
> package (and possibly but not necessarily cause a patch conflict).
> Only in cases were the change made by the patch is generic and not
> intended for a specific version, should we remove the version from the
> patch name.

A generic patch doesn't exist, a patch is *always* for a specific
version of a source tree. The fact that it might apply on multiple
versions of a given package is just pure luck. Therefore, I don't see
where the distinction between "generic patch" and a "version-specific"
patch is.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list