[Buildroot] [PATCH] toolchain: add user defined target LDFLAGS options

[Baruch Siach]

Hi Matias,

On Mon, Jul 25, 2011 at 05:19:00PM -0400, Matias Garcia wrote:
> On Mon, 2011-07-25 at 09:16 +0200, Peter Korsgaard wrote:
> > >>>>> "Baruch" == Baruch Siach <baruch at tkos.co.il> writes:
> > 
> >  >> What tree did you create this patch against? package/Makefile.in hasn't
> >  >> looked like that since April, so I had to apply the patch manually.
> > 
> >  Baruch> I mistakenly based this patch on version 2010.11.
> > 
> >  Baruch> Actually, since I use an external toolchain, the patch of
> >  Baruch> Matias Garcia
> >  Baruch> (http://lists.busybox.net/pipermail/buildroot/2011-July/043944.html,
> >  Baruch> not merged yet) solves the -te500v2 problem for me without this
> >  Baruch> patch, so I've dropped it locally.
> > 
> > Ok. That patch still needs some work (E.G. it only works with a single
> > argument).
> 
> Ah, that's something I hadn't considered. Thanks for the feedback. I was
> assuming one could pass something like "-fee -fi -fo -fum" in the text
> block, and this would be passed on to the wrapper.

Well, this string will be passed to the wrapper, but the whole string will get 
stored in the same args[] entry. This means that the compiler sees it as one 
long argument, not one argument per word as should be.

A possible solution might be to split this string with strtok() at run-time, 
but it looks inefficient, since we have all the information we need at compile 
time.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -