[Buildroot] [PATCH 3/3] disko-demos: new package

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Thanks, a few comments:

 Thomas> --- /dev/null
 Thomas> +++ b/package/multimedia/disko-demos/disko-demos-1.8.0-fix-install-paths.patch
 Thomas> @@ -0,0 +1,61 @@
 Thomas> +Allow proper configuration of /etc directory
 Thomas> +
 Thomas> +The disko-demos SConstruct build script forced to install
 Thomas> +configuration files into <prefix>/etc, which means /usr/etc. This
 Thomas> +patch adds a sysconfdir argument, which allows to specify a different
 Thomas> +directory for configuration files.
 Thomas> +
 Thomas> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Has this been sent upstream?

 Thomas> +++ b/package/multimedia/disko-demos/disko-demos.mk
 Thomas> @@ -0,0 +1,27 @@
 Thomas> +

Please drop this empty line.

 Thomas> +DISKO_DEMOS_VERSION = 1.8.0
 Thomas> +DISKO_DEMOS_SOURCE = disko-demos_$(DISKO_DEMOS_VERSION).tar.gz
 Thomas> +DISKO_DEMOS_SITE = http://www.diskohq.com/repository/sources/
 Thomas> +
 Thomas> +DISKO_DEMOS_DEPENDENCIES = disko
 Thomas> +
 Thomas> +DISKO_DEMOS_SCONS_ENV = 	 \
 Thomas> +	$(TARGET_CONFIGURE_OPTS)

No LD=$(TARGET_CC) like for disko?

-- 
Bye, Peter Korsgaard