[Buildroot] [PATCH 06/10] autotools: allow host package to use <pkg>_MAKE_ENV and <pkg>_MAKE

Peter Korsgaard jacmet at uclibc.org
Mon Jan 24 21:04:35 UTC 2011


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 Thomas> This will be needed by the Python interpreter package.
 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 Thomas> ---
 Thomas>  package/Makefile.autotools.in |    2 +-
 Thomas>  1 files changed, 1 insertions(+), 1 deletions(-)

 Thomas> diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
 Thomas> index de0a355..d445348 100644
 Thomas> --- a/package/Makefile.autotools.in
 Thomas> +++ b/package/Makefile.autotools.in
 Thomas> @@ -200,7 +200,7 @@ endif
 Thomas>  #
 Thomas>  ifndef $(2)_INSTALL_CMDS
 Thomas>  define $(2)_INSTALL_CMDS
 Thomas> -	$(HOST_MAKE_ENV) $(MAKE) -C $$($$(PKG)_SRCDIR) install
 Thomas> +	$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) -C $$($$(PKG)_SRCDIR) install

Hmm, I don't really like this. Packages might be adding target specific
stuff to their $PKG_MAKE_ENV - E.G.:

lvm2/lvm2.mk:LVM2_MAKE_ENV = CC="$(TARGET_CC)"

Wouldn't it make more sense to add a HOST_$PKG_MAKE_ENV and use it just
like we do for $PKG_MAKE_ENV (E.G. at build and install time)?

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list