[Buildroot] [PATCH] Makefile.package.in: accept upper case $(PKG)_SITE_METHOD as well

Bjørn Forsman bjorn.forsman at gmail.com
Tue Feb 1 11:12:37 UTC 2011


On 1 February 2011 08:59, Daniel Nyström <daniel.nystrom at timeterminal.se> wrote:
> 2011/1/31 Bjørn Forsman <bjorn.forsman at gmail.com>:
>> On 31 January 2011 23:30, Daniel Nyström <daniel.nystrom at timeterminal.se> wrote:
>>> 2011/1/31 Bjørn Forsman <bjorn.forsman at gmail.com>:
>>>> The Buildroot documentation says it's OK to use upper case names for
>>>> $(PKG)_SITE_METHOD, but the implementation does not support it. This
>>>> patch adds support for both upper and lower case names.
>>>
>>> In my opinion changing the documentation is a better way to go since
>>> it would make the mk files uniformed.
>>
>> I'm not sure I understand what you mean by "uniformed". Can you give an example?
>>
>> My idea of uniform .mk files would actually be to use upper case, as
>> there is already lots of upper case in BR. Am I wrong?
>
> You're absolutely right, upper case seems to be most common. But it
> also seems like no other options (for example PKG_INSTALL_STAGING)
> handles both upper and lower case which I consider a good thing since
> it's what makes the mk files uniformed. :)
> See: http://git.buildroot.net/buildroot/tree/package/Makefile.package.in#n454

All right, I'll resend. Ignore this patch then.


More information about the buildroot mailing list