[Buildroot] [PATCH] package: Adding Next Generation IRC deamon ngircd

Daniel Nyström daniel.nystrom at timeterminal.se
Wed Apr 20 08:05:34 UTC 2011


Hi Fabien!

Thanks for contributing. Just a few comments below:

2011/4/20  <fabien.marteau at armadeus.com>:
> From: Fabien Marteau <fabien.marteau at armadeus.com>
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_NGIRCD
> +       bool "ngircd"
> +       help
> +               Next Generation IRC server deamon.
> +               http://ngircd.barton.de
> +

The current format uses 1 tab for identation (as you've done) but 1
tab + 2 spaces for help text. And please put the blank line between
the description and the URL instead. :)
An ideal example: http://git.buildroot.net/buildroot/tree/package/file/Config.in

> +++ b/package/ngircd/ngircd.mk
> @@ -0,0 +1,11 @@
> +NGIRCD_CONF_OPT =

Since you do not specify any CONF_OPT you could just remove the line completely.


More information about the buildroot mailing list