[Buildroot] [PATCH 20/21] BugFix - Bison - Fixed Missing stddef.h Include In wchar.h

Martin Banky Martin.Banky at gmail.com
Wed Sep 15 01:45:18 UTC 2010


Thomas,
     I'll work on making the changes a little later. I'm in the middle of a
test build for some changes that I'm making in other areas.

Martin

On Tue, Sep 14, 2010 at 12:54 PM, Thomas Petazzoni <
thomas.petazzoni at free-electrons.com> wrote:

> Hello Martin,
>
> Thanks for your patchset !
>
> On Mon, 13 Sep 2010 20:40:47 -0700
> Martin Banky <martin.banky at gmail.com> wrote:
>
> > +BISON_DIR:=$(BUILD_DIR)/bison-$(BISON_VERSION)
>
> This is not needed and shouldn't be there.
>
> >  define BISON_DISABLE_EXAMPLES
> >       echo 'all install:' > $(@D)/examples/Makefile
> >  endef
> >
> > +define BISON_NO_WCHAR_SUPPORT
> > +     toolchain/patch-kernel.sh $(BISON_DIR)
> package/bison/bison-no-wchar/ \*.patch
> > +endef
> > +
> > +ifneq ($(BR2_USE_WCHAR),y)
> > +BISON_POST_CONFIGURE_HOOKS += BISON_NO_WCHAR_SUPPORT
> > +endif
>
> Personally, I'd prefer not to have patches applied conditionally. It's
> the patch itself that should do the right thing depending on whether
> wchar support is available or not, so that the patch can eventually be
> sent to the upstream project.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100914/6650808a/attachment.html>


More information about the buildroot mailing list