[Buildroot] [PATCH] Fix 'make source' when used with external toolchains

[Quotient Remainder]

Ar Aoine, 2010-09-10 ag 13:59 +0100, scríobh Phil Edworthy:
> When you do 'make source', Buildroot unconditionally downloads gcc and
> binutils/mpfr. When using an external toolchain, BR2_GCC_VERSION isn't set
> so the download fails. 
> 
> This patch makes the download conditional.

This is great and does seem to work.  I had done a long and rambling
diagnosis and had figured out that this was the problem.
I was about to send to the list for proposed solutions because I feared
that just disabling the specific lines wasn't the right approach.

The one observation I have is that if I patch like this:

diff --git a/Makefile b/Makefile
index 462d974..88e17d1 100644
--- a/Makefile
+++ b/Makefile
@@ -437,6 +437,10 @@ endif
 
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)
 
+show-source-targets:
+	@echo Targets: $(TARGETS_SOURCE)
+	@echo Host: $(HOST_SOURCE)
+
 _source-check:
 	$(MAKE) $(EXTRAMAKEARGS) SPIDER=--spider source
 

and do "make show-source-targets", I get this

$ make show-targets show-source-targets
busybox target-finalize target-generic-hostname target-generic-issue ext2-root erase-fakeroots
Targets: busybox-source target-finalize-source target-generic-hostname-source target-generic-issue-source ext2-root-source erase-fakeroots-source uclibc-source
Host:

i.e. uclibc-source is in the target list for "make source".

Does this have the potential to cause a problem?