[Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269

Peter Korsgaard jacmet at uclibc.org
Tue Jul 27 08:53:09 UTC 2010


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

Hi,

 Thomas> + install: setserial setserial.8
 Thomas> +-	$(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
 Thomas> ++	mkdir -p $(DESTDIR)/usr/bin
 Thomas> ++	$(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
 Thomas> + 	$(STRIP) $(DESTDIR)/bin/setserial
 >> 
 >> That strip should go.

 Thomas> Well, it was here in the setserial Makefile. While I agree that we
 Thomas> shouldn't explicitly add strip commands in Buildroot .mk files, I don't
 Thomas> think it's worth the effort removing those strip commands from within
 Thomas> the package.

No, but it was stripping bin/setserial, not usr/bin/setserial.


-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list