[Buildroot] [PATCH] Permit building grub with an external toolchain.

Clark Rawlins clark.rawlins at escient.com
Sun Jan 17 00:59:20 UTC 2010


Ping?

Is there anything wrong with this patch that should be fixed prior to
its inclusion in master?

On Mon, 2010-01-04 at 12:48 -0500, Clark Rawlins wrote:
> I have attached the complete file for review as well as the git
> format-patch generated diff.
> 
> On Mon, 2010-01-04 at 08:29 -0500, Clark Rawlins wrote:
> > On Mon, 2010-01-04 at 14:20 +0100, Thomas Petazzoni wrote:
> > > Hello Clark!
> > > 
> > > Le Mon, 04 Jan 2010 08:01:44 -0500,
> > > Clark Rawlins <clark.rawlins at escient.com> a écrit :
> > > 
> > > > Here is my attempt to use the autotools macros.
> > > > I look forward to any discussion, suggestions for improvement etc.
> > > > 
> > > > I attach the whole file since it is effectively a rewrite.  If it is
> > > > acceptable I will submit as a git diff against head.  
> > > 
> > > Thanks for your work.
> > > 
> > > Maybe the GRUB_SUPPORTED_ARCH thing should be handled at the
> > > Config.in level.
> > 
> > Of course I was just copying what was already there for that part.
> > 
> > In grub/Config.in BR2_TARGET_GRUB depends on BR2_i386 || BR2_x86_64.
> > It seems that it would be equivalent to replace all the
> > GRUB_SUPPORTED_ARCH stuff with a single check for 
> > 
> > ifeq ($(BR2_TARGET_GRUB),y)
> > 
> > endif
> > 
> > > 
> > > Thomas
> > > -- 
> > > Thomas Petazzoni, Free Electrons
> > > Kernel, drivers and embedded Linux development,
> > > consulting, training and support.
> > > http://free-electrons.com
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot at busybox.net
> > > http://lists.busybox.net/mailman/listinfo/buildroot
> > 
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



More information about the buildroot mailing list