[Buildroot] [PATCH] netperf: add Gentoo patch to fix buffer overflow compiler warnings
Heiko Zuerker
heiko at zuerker.org
Mon Dec 27 20:53:58 UTC 2010
Quoting Peter Korsgaard <jacmet at uclibc.org>:
>>>>>> "heiko" == heiko <heiko at zuerker.org> writes:
>
> heiko> From: Heiko Zuerker <smiley73 at users.sourceforge.net>
> heiko> Signed-off-by: Heiko Zuerker <smiley73 at users.sourceforge.net>
> heiko> ---
> heiko> package/netperf/netperf-2.4.5-netserver.patch | 51
> +++++++++++++++++++++++++
>
> So this just fixes a build warning, and otherwise doesn't affect the
> resulting binaries?
I "borrowed" this patch from Gentoo and my C skills are very basic.
But from what I understand it just ge'st rid of the warnings but
doesn't change the functionality.
I do use a hardened toolchain for my compile and they won't compile
the code without the modification.
> heiko> ++++ b/src/netserver.c
> heiko> +@@ -142,7 +142,7 @@
> heiko> +
> heiko> + #ifndef DEBUG_LOG_FILE
> heiko> + #ifndef WIN32
> heiko> +-#define DEBUG_LOG_FILE "/tmp/netperf.debug"
> heiko> ++#define DEBUG_LOG_FILE "/var/log/netperf.debug"
>
> What's the reason for this change?
I left this in the patch on purpose, since log files belong into
/var/log and not /tmp.
--
Regards
Heiko Zuerker
http://www.devil-linux.org
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
More information about the buildroot
mailing list