[Buildroot] [PATCH 47/55] linux: support a space-separated list of patches

Peter Korsgaard jacmet at uclibc.org
Fri Dec 17 09:41:18 UTC 2010


>>>>> "Mike" == Mike Frysinger <vapier at gentoo.org> writes:

 Mike> On Thursday, December 16, 2010 16:34:18 Peter Korsgaard wrote:
 >> case "$$p" in
 >> http://*|http://*)

 Mike> guessing you meant ftp://|http://

Ehh, sure.

 Mike> also, this patch reminds me of common problem in buildroot.  why do people use 
 Mike> `dirname` and `basename` ?  these really should be letting the shell do it 
 Mike> like ${f##*/} and ${f%/*}.  or use make's builtins.

You cannot use make function as it's part of a shell loop, but shell
builtins could be used, sure - Even though shell parameter expansion in
combination with make escape rules starts to resemble line noise ;)

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list