[Buildroot] [PATCH 02/41] ncurses: convert to autotools infrastructure

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Apr 14 13:17:41 UTC 2010


Hello,

Oops, I missed something here.

On Wed, 14 Apr 2010 01:05:35 +0200
llandwerlin at gmail.com wrote:

> +define NCURSES_PATCH_NCURSES_CONFIG
>  	$(SED) 's^prefix="^prefix="$(STAGING_DIR)^' \
>  		$(STAGING_DIR)/bin/ncurses5-config
> -	touch -c $@
> +endef
> +
> +NCURSES_POST_BUILD_HOOKS += NCURSES_PATCH_NCURSES_CONFIG

I don't understand how this can be a post-build hook. After build,
ncurses is not yet installed in $(STAGING_DIR). Shouldn't this be a
post-staging-install hook instead ?

And BTW, your patch 3/41 should probably be just folded into this 2/41
patch. But it's not really important.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list