[Buildroot] [Bug 683] SDL-dfb does not select directfb

bugzilla at busybox.net bugzilla at busybox.net
Tue Oct 27 16:28:28 UTC 2009


https://bugs.busybox.net/show_bug.cgi?id=683





--- Comment #2 from Peter Korsgaard <jacmet at uclibc.org>  2009-10-27 16:28:28 UTC ---
(In reply to comment #1)
> Thanks Damien for reporting the issue.
> 
> I'm wondering whether we should use a select as you suggested, or a depends on.
> We usually use "select" so that the user doesn't need to care about missing
> dependencies. But in the case of DirectFB, many things can (and should ?) be
> configured at the DirectFB level, so I'm not sure that selecting DirectFB
> behind the user's back is good.
> 
> something like:
> 
>  config BR2_PACKAGE_SDL_DIRECTFB
>         bool "SDL DirectFB video driver"
> +       depends on BR2_PACKAGE_DIRECTFB
> 
> + comment "sdl-dfb requires directfb support"
> +        depends on !BR2_PACKAGE_DIRECTFB
> 
> Peter, your opinion on this ?

We should imho use depends on (and also for the qt/x11 backends) similar to how
it is done for E.G. libgtk2.

Notice that the dependencies in the makefile are likewise missing.


-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the buildroot mailing list