[Buildroot] [PATCH 06/10] *-menuconfig needs dirs to exist

[Bernhard Reutner-Fischer]

On Fri, Oct 09, 2009 at 01:35:29PM +0200, Peter Korsgaard wrote:

>I have no problem adding fixes, but I want to understand what - if
>anything, it fixes.

one last attempt.

$ rm -rf buildroot
$ git clone --depth 1 git://git.uclibc.org/git/buildroot.git && cd buildroot
$ make
select linux kernel, same as headers. Set format to e.g. bzImage; save
and exit. you have e.g.:
$ egrep "^BR2_(.*LINUX|KERNEL)" .config
BR2_KERNEL_MIRROR="http://www.kernel.org/pub/"
BR2_KERNEL_HEADERS_2_6_31=y
BR2_KERNEL_LINUX=y
BR2_PACKAGE_LINUX=y
BR2_PACKAGE_LINUX_KCONFIG=""
BR2_PACKAGE_LINUX_FORMAT="bzImage"

cool, so let's configure the beast:
$ make linux26-menuconfig
--2009-10-09 13:43:42--
http://www.kernel.org/pub//linux/kernel/v2.6//linux-2.6.31.2.tar.bz2
Resolving proxy.loc... 192.168.100.36
Connecting to proxy.loc|192.168.100.36|:3128... connected.
Proxy request sent, awaiting response... 200 OK
Length: 61449156 (59M) [application/x-bzip2]
Saving to: `./dl/linux-2.6.31.2.tar.bz2'

100%[======================================>] 61,449,156   384K/s   in
2m 35s  

2009-10-09 13:46:19 (387 KB/s) - `./dl/linux-2.6.31.2.tar.bz2' saved
[61449156/61449156]

rm -rf /tmp/buildroot/output/build/linux-2.6.31.2
*** Unpacking kernel source
bzcat ./dl/linux-2.6.31.2.tar.bz2 | tar -C /tmp/buildroot/output/build
-xf -
tar: /tmp/buildroot/output/build: Cannot chdir: No such file or
directory
tar: Error is not recoverable: exiting now
make: *** [/tmp/buildroot/output/build/linux-2.6.31.2/.unpacked] Error 2

Note that this is an obvious breakage. Look at the makefiles, who do you
think should have created the build-dir before that?
And yes, just BUILD_DIR, like busybox does would be sufficient, but
later on you will experience that if you just specify BUILD_DIR as
prereq then you will die in funny ways for toplevel-parallel makes.
(I can almost hear you saying that this isn't supported right now, so:
yes, it isn't but let's just fix it properly to avoid this future
problem, ok?)

.