[Buildroot] [PATCH] qtopia4: fix wrong variable name for SQL

Thiago A. Corrêa thiago.correa at gmail.com
Mon Nov 3 12:13:46 UTC 2008


>>>>>> "Markus" == Markus Heidelberg <markus.heidelberg at web.de> writes:
>
> Hi,
>
>  >> Btw, could you send patches as attachments (instead or as well)? Not
>  >> sure how others prefers them,
>
>  Markus> I prefer inline patches, for easier commenting for example. I
>  Markus> also find attachments are quite annoying if I have to use the
>  Markus> web archives and can't just read the patch but have to
>  Markus> download it at first. I know Peter prefers inline for the
>  Markus> ease of applying them with "git am" and he has already
>  Markus> applied a few from me.
>
> Exactly!

I don't use git, and I guess I never will *smile*.

I agree it's best for commenting, but if it were also as well easier
to apply, then it means the submitter doesn't have to wait for Peter
to have the time to check it. I or someone else with the same problem
as me could do it.

>  >> Also, I don't trust copy and paste
>  >> to not mess with the whitespaces and tabs.... If I do mess them up
>  >> others jump on my neck. Whitespace damage is sort of worst than having
>  >> a non working package around here *smile*.
>
>  Markus> If whitespace is damaged after copy and paste, you will
>  Markus> notice it when applying the malformed patch.
>
> Yes.
>
> Thiago, what keeps you from using a proper email client?
>

I get rejects whenever I try to apply those git generated patches. It
just occured to me that maybe if I use the "show original" in the
gmail and copy from that it should work better. Will see in the next
patches if this works ;)



More information about the buildroot mailing list