[Buildroot] patch to allow selection of e2fsprogs tools toinstall

Hamish Moffatt hamish at cloud.net.au
Thu Feb 21 05:20:15 UTC 2008


On Thu, Feb 21, 2008 at 05:36:25AM +0100, Ulf Samuelsson wrote:
> That doesn't work so I assume it was never tested.
> Pls test before you resubmit.

I did, and it works for me.

> $(E2FSPROGS_RM) is always clear
> $(E2FSPROGS_RM-y) and $(E2FSPROGS_RM-n) may have contents.

No,

> > +E2FSPROGS_RM$(strip $(BR2_PACKAGE_E2FSPROGS_BADBLOCKS)) += ${TARGET_DIR}/sbin/badblocks
> > +E2FSPROGS_RM$(strip $(BR2_PACKAGE_E2FSPROGS_BLKID)) += ${TARGET_DIR}/sbin/blkid

$(E2FSPROGS_RM-*) is not used, it is $(E2FSPROGS_RM)y and
$(E2FSPROGS_RM). I could have used RM-, but I thought $(E2FSPROGS_RM-)
looked odd.

Hence,

> > +ifneq ($(strip $(E2FSPROGS_RM)),)
> > + rm -rf $(E2FSPROGS_RM)
> > +endif


Hamish
-- 
Hamish Moffatt VK3SB <hamish at debian.org> <hamish at cloud.net.au>



More information about the buildroot mailing list